Fix Dependabot security alerts: cryptography, Pygments, keccak, atty#11
Conversation
Agent-Logs-Url: https://github.com/Johnsonajibi/DeviceFingerprinting/sessions/9e0b3a25-1c13-492a-b150-fa329021b774 Co-authored-by: Johnsonajibi <78730285+Johnsonajibi@users.noreply.github.com>
…, atty dependencies Agent-Logs-Url: https://github.com/Johnsonajibi/DeviceFingerprinting/sessions/9e0b3a25-1c13-492a-b150-fa329021b774 Co-authored-by: Johnsonajibi <78730285+Johnsonajibi@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Resolves multiple Dependabot security alerts by updating Python and Rust dependencies to patched versions and regenerating Rust lockfiles.
Changes:
- Python: bump
cryptographyminimum version and add an explicitPygmentsminimum version constraint. - Rust: bump
sha3andcbindgen, regenerating bothCargo.lockfiles to removeattyand pull patchedkeccak.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
requirements.txt |
Bumps cryptography and adds a direct Pygments constraint. |
pyproject.toml |
Bumps cryptography minimum version in package metadata. |
rust/Cargo.toml |
Bumps sha3 and cbindgen to versions intended to address advisories. |
rust/Cargo.lock |
Regenerated lockfile reflecting updated dependency graph (incl. patched keccak, removed atty). |
pqc_rust_src/Cargo.toml |
Bumps sha3 to align with patched keccak. |
pqc_rust_src/Cargo.lock |
Regenerated lockfile reflecting updated dependency graph (incl. patched keccak, removed atty). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dependencies = [ | ||
| "numpy>=1.21.0", | ||
| "scikit-learn>=1.0.0", | ||
| "psutil>=5.8.0", | ||
| "cryptography>=43.0.0", # Updated for security fixes | ||
| "cryptography>=44.0.1", # Updated for security fixes (buffer overflow CVE, DNS constraint CVE) | ||
| "keyring>=23.0.0", | ||
| "certifi>=2024.7.4", # Updated for security fixes | ||
| ] |
There was a problem hiding this comment.
Pygments>=2.15.1 was added to requirements.txt, but the PR description indicates adding an explicit constraint for the Python dependency tree (including pyproject.toml). If users install via the package metadata ([project].dependencies / extras), this file still leaves Pygments unconstrained; consider adding the same minimum version to pyproject.toml (likely under the appropriate extra such as docs if it’s only pulled by Sphinx), so the Dependabot alert is actually resolved for that resolver path too.
Resolves 4 open Dependabot alerts across Python and Rust dependency trees by bumping to patched versions.
Python (
requirements.txt,pyproject.toml)>=43.0.0→>=44.0.1>=2.15.1added as explicit constraint (was unconstrained transitive dep)Rust (
rust/,pqc_rust_src/)0.10→0.11in bothCargo.tomlfiles — sha3 0.11 pulls keccak 0.2.0 (was 0.1.5/0.1.6)0.24→0.29inrust/Cargo.toml— cbindgen 0.26+ uses clap 4.x, which drops theattydependency entirelyatty(no patched atty release exists; removing the dep is the correct fix)Both
Cargo.lockfiles regenerated —atty0.2.14 is fully absent from both dependency graphs.Original prompt
This pull request was created from Copilot chat.