add normalized_weighted averaging method to get_averaged_metric()#409
Open
JaisalJain wants to merge 2 commits intoJdeRobot:masterfrom
Open
add normalized_weighted averaging method to get_averaged_metric()#409JaisalJain wants to merge 2 commits intoJdeRobot:masterfrom
JaisalJain wants to merge 2 commits intoJdeRobot:masterfrom
Conversation
JaisalJain
force-pushed
the
fix/weighted-average-normalization
branch
from
0b3b1d8 to
e9abcbb
Compare
JaisalJain
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
As suggested by @dpascualhe, this PR adds
normalized_weightedas a new averaging method rather than modifying the existingweightedbehavior.New method:
normalized_weighteddivides by the sum of weights, ensuring the result stays within [0, 1].Existing behavior unchanged:
weightedcontinues to return the raw dot product for backward compatibility.Changes: