Replace Size with ByteSize#482
Merged
JakeWharton merged 1 commit intoJakeWharton:trunkfrom Mar 16, 2026
Merged
Conversation
JakeWharton
reviewed
Mar 16, 2026
Comment on lines
+27
to
+28
| assertThat(entry.compressedSize).isEqualTo(7.binaryBytes) | ||
| assertThat(entry.uncompressedSize).isEqualTo(5.binaryBytes) |
Comment on lines
+6
to
+7
| val BinaryByteSize.absoluteValue: BinaryByteSize | ||
| get() = BinaryByteSize(inWholeBytes.absoluteValue) |
Owner
There was a problem hiding this comment.
This is only used in one place. We can inline it.
Contributor
Author
There was a problem hiding this comment.
I'm sending a PR to add this for BinaryByteSize, so we can todo and remove it later.
| val ZERO = Size(0) | ||
| } | ||
| } | ||
| operator fun BinaryByteSize.unaryMinus() = BinaryByteSize(-inWholeBytes) |
formats/api/formats.api
Outdated
Comment on lines
+103
to
+104
| public final fun component3-7zWN8Bo ()J | ||
| public final fun component4-7zWN8Bo ()J |
Contributor
Author
There was a problem hiding this comment.
Yeah, will address that in a follow-up.
formats/src/main/kotlin/com/jakewharton/diffuse/format/ArchiveFile.kt
Outdated
Show resolved
Hide resolved
reports/src/main/kotlin/com/jakewharton/diffuse/diff/ArchiveFilesDiff.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.