ci: demo Checkstyle in static analysis by baptistegrimaud · Pull Request #478 · Jahia/javascript-modules

baptistegrimaud · 2025-09-04T19:44:36Z

Description

...

Checklist

Source code

I've shared and documented any breaking change
I've reviewed and updated the jahia-depends

Tests

I've provided Unit and/or Integration Tests
I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

jahia-ci · 2025-09-04T20:23:35Z

...java/org/jahia/modules/javascript/modules/engine/jshandler/JavascriptProtocolConnection.java

                    }
                    // Map everything else in settings/ to META-INF/
-                    else {
+                    else


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> _{reported by reviewdog 🐶}
'else' construct must use '{}'s.

jahia-ci

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 80 in 32ea546

for (Bundle bundle : getJavascriptModules()) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 81 in 32ea546

engine.disableJavascriptModule(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 82 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 83 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 85 in 32ea546

@Override

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 86 in 32ea546

public void bundleChanged(BundleEvent event) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 87 in 32ea546

try {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 88 in 32ea546

Bundle bundle = event.getBundle();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 89 in 32ea546

if (isJavascriptModule(bundle)) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 90 in 32ea546

if (event.getType() == BundleEvent.STARTED) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 91 in 32ea546

engine.enableJavascriptModule(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 92 in 32ea546

for (Registrar registrar : registrars) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 93 in 32ea546

registrar.register(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 94 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 95 in 32ea546

} else if (event.getType() == BundleEvent.STOPPED) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 96 in 32ea546

for (Registrar registrar : registrars) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 97 in 32ea546

registrar.unregister(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 98 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 99 in 32ea546

engine.disableJavascriptModule(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 100 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 101 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 102 in 32ea546

} catch (Exception e) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 103 in 32ea546

logger.error("Cannot handle event {}", event.toString(), e);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 104 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 105 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 107 in 32ea546

public List<Bundle> getJavascriptModules() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 108 in 32ea546

return Arrays.stream(engine.getBundleContext().getBundles())

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 109 in 32ea546

    
           .filter(bundle -> bundle.getState() == Bundle.ACTIVE && isJavascriptModule(bundle))

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 110 in 32ea546

.collect(Collectors.toList());

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 111 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 113 in 32ea546

public boolean isJavascriptModule(Bundle bundle) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 114 in 32ea546

    
           return bundle.getBundleId() != engine.getBundleContext().getBundle().getBundleId() &&

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 115 in 32ea546

bundle.getHeaders().get(BUNDLE_HEADER_JAVASCRIPT_INIT_SCRIPT) != null;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 116 in 32ea546

}

jahia-ci · 2025-09-05T09:45:27Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

-        return bundle.getBundleId() != engine.getBundleContext().getBundle().getBundleId() &&
-                bundle.getHeaders().get(BUNDLE_HEADER_JAVASCRIPT_INIT_SCRIPT) != null;
-    }
+	private static final Logger logger = LoggerFactory.getLogger(JavascriptModuleListener.class);


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:27Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

-                bundle.getHeaders().get(BUNDLE_HEADER_JAVASCRIPT_INIT_SCRIPT) != null;
-    }
+	private static final Logger logger = LoggerFactory.getLogger(JavascriptModuleListener.class);
+	private GraalVMEngine engine;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:28Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

-    }
+	private static final Logger logger = LoggerFactory.getLogger(JavascriptModuleListener.class);
+	private GraalVMEngine engine;
+	private final Queue<Registrar> registrars = new ConcurrentLinkedQueue<>();


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:28Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+	private GraalVMEngine engine;
+	private final Queue<Registrar> registrars = new ConcurrentLinkedQueue<>();
+
+	@Reference(cardinality = ReferenceCardinality.MANDATORY)


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:28Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+	private final Queue<Registrar> registrars = new ConcurrentLinkedQueue<>();
+
+	@Reference(cardinality = ReferenceCardinality.MANDATORY)
+	public void setEngine(GraalVMEngine engine) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:29Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+			engine.enableJavascriptModule(bundle);
+		}
+
+		context.addBundleListener(this);


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:29Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+		}
+
+		context.addBundleListener(this);
+	}


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:29Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+		context.addBundleListener(this);
+	}
+
+	@Deactivate


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:29Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+	}
+
+	@Deactivate
+	public void deactivate(BundleContext context) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

jahia-ci · 2025-09-05T09:45:30Z

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

+
+	@Deactivate
+	public void deactivate(BundleContext context) {
+		context.removeBundleListener(this);


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

baptistegrimaud force-pushed the guild-day-linting-checkstyles branch from 0d0f87c to 63070bc Compare September 4, 2025 19:59

jahia-ci reviewed Sep 4, 2025

View reviewed changes

ci: Demo Checkstyle in static analysis

32ea546

baptistegrimaud force-pushed the guild-day-linting-checkstyles branch from 1b8652c to 32ea546 Compare September 5, 2025 09:45

jahia-ci reviewed Sep 5, 2025

View reviewed changes

baptistegrimaud changed the title ~~ci: add Checkstyle~~ ci: demo Checkstyle in static analysis Sep 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

ci: demo Checkstyle in static analysis#478

ci: demo Checkstyle in static analysis#478
baptistegrimaud wants to merge 1 commit intomainfrom
guild-day-linting-checkstyles

baptistegrimaud commented Sep 4, 2025

Uh oh!

jahia-ci Sep 4, 2025

Uh oh!

jahia-ci left a comment

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

jahia-ci Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

baptistegrimaud commented Sep 4, 2025

Description

Checklist

Source code

Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jahia-ci left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants