Skip to content

Use drop=FALSE to avoid losing dimension in double-elided case #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelChirico wants to merge 2 commits into from
Closed

Use drop=FALSE to avoid losing dimension in double-elided case #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7010e3
Use drop=FALSE to avoid losing dimension in double-elided case
MichaelChirico May 9, 2025
9d14b16
correct local_options() call
MichaelChirico May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions R/repr_matrix_df.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ arr_partition <- function(a, rows, cols) {
# assign a list of parts that can be coerced to strings
if (!is.null(part_r) && !is.null(part_c)) {
structure(list(
ul = a[part_r$start, part_c$start], ll = a[part_r$end, part_c$start],
ur = a[part_r$start, part_c$end ], lr = a[part_r$end, part_c$end ]),
ul = a[part_r$start, part_c$start, drop = FALSE],
ll = a[part_r$end , part_c$start, drop = FALSE],
ur = a[part_r$start, part_c$end, drop = FALSE],
lr = a[part_r$end , part_c$end, drop = FALSE]),
omit = 'both')
} else if (!is.null(part_r)) {
structure(list(
Expand Down
22 changes: 22 additions & 0 deletions tests/testthat/test_repr_array_df.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,3 +204,25 @@ test_that('data.frame with list columns can be displayed', {
expect_identical(repr_html(data.table::as.data.table(df)), sub('data\\.frame','data.table',expected))
}
})

test_that('forced-narrow inputs work', {
withr::local_options(list(repr.matrix.max.rows = 2L, repr.matrix.max.cols = 2L))
df <- data.frame(a = 1:3, b = 4:6, c = 7:9)
expect_silent(repr_text(df))
expect_identical(
# Scrub non-ASCII characters to make the test platform-agnostic.
gsub("[^a-zA-Z0-9.&;<>= '\"/:\n\t]", "*", repr_html(df)),
"<table class=\"dataframe\">
<caption>A data.frame: 3 * 3</caption>
<thead>
\t<tr><th scope=col>a</th><th scope=col>*</th><th scope=col>c</th></tr>
\t<tr><th scope=col>&lt;int&gt;</th><th scope=col>*</th><th scope=col>&lt;int&gt;</th></tr>
</thead>
<tbody>
\t<tr><td>1</td><td>*</td><td>7</td></tr>
\t<tr><td>*</td><td>*</td><td>*</td></tr>
\t<tr><td>3</td><td>*</td><td>9</td></tr>
</tbody>
</table>
")
})