-
Notifications
You must be signed in to change notification settings - Fork 10
Use Cases of Download with Guestbooks #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jp-tosca
merged 21 commits into
develop
from
424-use-cases-to-support-download-terms-of-use-and-guestbook
Mar 20, 2026
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c023fd5
feat: Add Guestbook and Access Repository, and their use cases accord…
ChengShi-1 1f61ab1
use other image tag for test
ChengShi-1 812dd22
fix: test failing
ChengShi-1 c3f76f8
fix: copilot reviews
ChengShi-1 bba1993
fix: update collectionId to Uppercase
ChengShi-1 4dd5c4c
feat: update use cases of guestbook and access
ChengShi-1 88fb521
chore: update usecases.md
ChengShi-1 1aa3e31
feat: add guestId to dataset
ChengShi-1 f4e6bd4
chore: changelog
ChengShi-1 3fe127d
fix: update usecases
ChengShi-1 2fb1ccc
fix: remove consolelog
ChengShi-1 a4fe19a
fix: update datasetType model
ChengShi-1 63ce2d8
fix: update changelog and usecase md
ChengShi-1 92f65b3
fix: tests and createGuestbookDTO
ChengShi-1 26163fe
fix: createGuestbook returns ID
ChengShi-1 d6e8ca8
Merge branch 'develop' into 424-use-cases-to-support-download-terms-o…
ChengShi-1 cbf44c0
fix: unit test
ChengShi-1 bc7726b
Merge branch '424-use-cases-to-support-download-terms-of-use-and-gues…
ChengShi-1 5f5cdd2
fix: unit test
ChengShi-1 199cf25
update env
ChengShi-1 b3bb1e5
Merge remote-tracking branch 'origin/develop' into 424-use-cases-to-s…
jp-tosca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| export interface GuestbookAnswerDTO { | ||
| id: number | string | ||
| value: string | string[] | ||
| } | ||
|
|
||
| export interface GuestbookResponseDTO { | ||
| guestbookResponse: { | ||
| name?: string | ||
| email?: string | ||
| institution?: string | ||
| position?: string | ||
| answers?: GuestbookAnswerDTO[] | ||
| } | ||
| } | ||
|
Comment on lines
+6
to
+14
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. answers should also be an optional field |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a const for enabled boolean