Merged
Conversation
New interface from osrf#85
This is a dangerous practice becuse the default values could be mutated. And it should always be passed in. Supercedes osrf#286
* add: type hints for parser argument --------- Co-authored-by: Tully Foote <tully.foote@gmail.com>
* add: link to pixi_rocker repo * docs: Add links to external rocker extensions * docs: add section on externally maintained rocker wrappers
* Barebones extension * Add expected format to help message * Add tests for ulimit extension --------- Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
…aking up all disk space. Especially for the tests. Also add option to top level for cleaning up the image on the CLI
The call to get_docker_client in setUpClass will fail if docker is not available on the host.
This test calls extend_cli_parser, which will fail if docker is not available.
* improve robustness of image cleanup * Don't automatically clean up a named image That makes the name useless * Remove unused output_callback As flagged in the review
* add rmw zenoh support to rmw plugin Fixes osrf#307 * Update to validate detecting multiple packages Also parameterize tests automatically * Move the expensive apt-get update after the installed test And only clean up once so repeated calls will hit the cache.
* add detach plugin * Implementing conflict feedback and resolution for default operating mode for detach and no-tty present. Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai> Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
Removing incorrect plural Fixes osrf#329
…rf#331) * Add resource limits extensions for CPU, memory, and shared memory - Enhanced ShmSize extension with build-time shm-size support via --shm-size-build - Added CpuLimits extension providing --cpus argument for runtime CPU limits - Added MemoryLimits extension providing --memory/-m argument for runtime memory limits - Extended core infrastructure to support docker build arguments from extensions - Added comprehensive input validation for memory and CPU formats - Updated documentation and added test coverage for all new functionality - Improved .gitignore with comprehensive Python and development file patterns These extensions expose docker build and runtime resource limit arguments (shm-size, cpus, memory) to rocker users, providing better control over container resource allocation. * Update .gitignore * Refactor resource constraint extensions per tfoote feedback - Move ShmSize, CpuLimits, and MemoryLimits to separate constraint_extensions.py file - Create reusable validate_memory_format() helper function to avoid code duplication - Enhance memory validation to support Docker byte-value formats (2b, 1024kb, 300m, 1gb) - Update CPU error message to "Expected a floating point number (e.g., '1.5')" - Update setup.py entry points to reference new constraint_extensions module --------- Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
* Restore interactive as the default behavior The comment is correct but this looks like it was changed in osrf#320 by accident. Co-authored-by: Scott K Logan <logans@cottsay.net> --------- Co-authored-by: Scott K Logan <logans@cottsay.net>
…rf#338) * Enable extension to parse their arguments and raise parser.errors In case their preconditions aren't met. * Skip CUDA install when host NVIDIA driver exists (fixes osrf#316) * Refine NVIDIA validation using parser.error per PR osrf#340 --------- Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
* Test for special '-1' (unlimited) value in ulimit * Accept special '-1' (unlimited) value in ulimit validation regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.