Skip to content

Make rpath option passed to clang command-line work on both Linux and MacOS#126

Merged
jamesthejellyfish merged 1 commit intoHuawei-CPLLab:mainfrom
ak1r4:bugfix/macos_fix
Feb 19, 2026
Merged

Make rpath option passed to clang command-line work on both Linux and MacOS#126
jamesthejellyfish merged 1 commit intoHuawei-CPLLab:mainfrom
ak1r4:bugfix/macos_fix

Conversation

@ak1r4
Copy link
Contributor

@ak1r4 ak1r4 commented Feb 17, 2026

Mac OS uses lld rather than ld, the rpath= syntax does not work on Mac OS. Switching it to rpath, should work well on both OSes.

(All tests ran successfully on MacOS Sequoia 15.6.1)

@ak1r4
Copy link
Contributor Author

ak1r4 commented Feb 17, 2026

I have another change that I plan to do to add macos to the GitHub CI, I will open a PR when it's ready.

@jamesthejellyfish jamesthejellyfish self-requested a review February 19, 2026 15:22
Copy link
Collaborator

@jamesthejellyfish jamesthejellyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@jamesthejellyfish jamesthejellyfish merged commit dc604b3 into Huawei-CPLLab:main Feb 19, 2026
2 checks passed
jamesthejellyfish pushed a commit to jamesthejellyfish/PyDSL that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants