Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the introductory vignette to correctly reference the reloaded/simplified tree sequence object (ts2) and improves a couple of explanatory comments, aligning with the PR intent (“ts” -> “ts2” is important).
Changes:
- Fixes a vignette call to use
ts2$num_individuals()afterts2 <- ts_load(ts_file). - Rewords comments around reticulate/table-collection usage for clarity.
- Tweaks phrasing describing the equivalence between the Rcpp implementation and the method on
TreeSequence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Thanks @hannesbecher! I squashed your commits, and ended up closing/destroying the PR, but since I did everything locally, I was still able to merge your code into What I did was: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"ts" -> "ts2" is important