Skip to content

Vignette suggestions#105

Closed
bryo-han wants to merge 0 commit intoHighlanderLab:mainfrom
bryo-han:main
Closed

Vignette suggestions#105
bryo-han wants to merge 0 commit intoHighlanderLab:mainfrom
bryo-han:main

Conversation

@bryo-han
Copy link

@bryo-han bryo-han commented Mar 2, 2026

"ts" -> "ts2" is important

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the introductory vignette to correctly reference the reloaded/simplified tree sequence object (ts2) and improves a couple of explanatory comments, aligning with the PR intent (“ts” -> “ts2” is important).

Changes:

  • Fixes a vignette call to use ts2$num_individuals() after ts2 <- ts_load(ts_file).
  • Rewords comments around reticulate/table-collection usage for clarity.
  • Tweaks phrasing describing the equivalence between the Rcpp implementation and the method on TreeSequence.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gregorgorjanc
Copy link
Member

Thanks @hannesbecher! I squashed your commits, and ended up closing/destroying the PR, but since I did everything locally, I was still able to merge your code into main - see your commit at 24ba558

What I did was:

gh pr checkout 105 -R HighlanderLab/RcppTskit
git rebase upstream/main

git reset --soft HEAD~3
git commit -m "Vignette improvements"
git push --force-with-lease bryo-han main
# I reckon the top command must have closed/destroyed the PR (maybe because I am not the owner? - this resest/commit/push works well for me on my end to squash commits)

git switch main
git merge bryo-han/main
git push upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants