Professor/Scholar skill rebalance - 2018 patch/renewal#3403
Open
guilherme-gm wants to merge 2 commits intoHerculesWS:rebalancefrom
Open
Professor/Scholar skill rebalance - 2018 patch/renewal#3403guilherme-gm wants to merge 2 commits intoHerculesWS:rebalancefrom
guilherme-gm wants to merge 2 commits intoHerculesWS:rebalancefrom
Conversation
- Fixed casting time reduced: 5s -> 2.5s From 1st/2nd/Transclass rebalance (2018.11.28)
- Reduce global delay to 0.5s on all skill levels* NOTE: iRO Wiki says it is on "all skill levels", while the official patch notes for kRO and iRO suggests it was generally reduced but only level 5 really gets 0.5s... We are following iRO Wiki here. From 1st/2nd/Transclass rebalance (2018.11.28)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I am still performing a self review/game check on this
Pull Request Prelude
Changes Proposed
This PR introduces the rebalance of Scholar/Professor job skills. This change affects Renewal-only.
I can't say everything is 100% accurate because they are based on sources and very few in-game tests, but should be close enough.
Commits authored by gbasso were mostly reused from #3200, which required rebase/commit split, reviewed but with minor/no change by me.
Check the commit messages for details of the changes (or the references below)
Affected skills
References:
Issues addressed:
Part of #2735