Fixed bDoubleRate should stack additively with Double Attack#3384
Draft
MrKeiKun wants to merge 1 commit intoHerculesWS:masterfrom
Draft
Fixed bDoubleRate should stack additively with Double Attack#3384MrKeiKun wants to merge 1 commit intoHerculesWS:masterfrom
MrKeiKun wants to merge 1 commit intoHerculesWS:masterfrom
Conversation
…r level. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
skyleo
reviewed
Sep 12, 2025
| || (sc != NULL && sc->data[SC_KAGEMUSYA] != NULL && sd->weapontype1 != W_FIST) // Need confirmation | ||
| ) { | ||
| // Success chance is not added, the higher one is used [Skotlex] | ||
| if (rnd() % 100 < (5 * skill_lv > sd->bonus.double_rate ? 5 * skill_lv : sc != NULL && sc->data[SC_KAGEMUSYA] != NULL ? sc->data[SC_KAGEMUSYA]->val1 * 3 : sd->bonus.double_rate)) |
Contributor
There was a problem hiding this comment.
Didn't this already have a higher chance (the one based on skill level) when sd->bonus.double_rate is lower which it usually is for Sidewinder Card?
skyleo
reviewed
Sep 12, 2025
| hitpercbonus += skill_lv; | ||
| } | ||
| // Success chance is not added, the higher one is used [Skotlex] | ||
| if (rnd() % 100 < min(100, 5 * skill_lv + sd->bonus.double_rate + (sc != NULL && sc->data[SC_KAGEMUSYA] != NULL ? sc->data[SC_KAGEMUSYA]->val1 * 3 : 0))) |
Contributor
There was a problem hiding this comment.
This would mean that one has a higher chance to cause Double Attack with Sidewinder Card equipped o-o
Contributor
Author
|
i'll move this to WIP, i haven't dug out the official mechanics for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed: #1660