Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
after your latest update (https://www.gurux.fi/comment/30893) I realised, that the implementation is still missing some key components.
I did more implementation, to fully support key agreement:
I verified the implementation of the keyagreement only for the client side when comunicating with real meter.
What needs to be verified is the server implementation. And there is missing step in the server implementation, to update keys in the settings (but only if this security setup is the one used for current connection and it needs to update the keys after response is sent).
I hope this will help and you will be able to accept most of the changes. Most of the changes and new methods are compatible with the rest of the library.