Fix optional translation fields in websocket Error model#226
Merged
GrandMoff100 merged 1 commit intodevfrom Mar 1, 2026
Merged
Fix optional translation fields in websocket Error model#226GrandMoff100 merged 1 commit intodevfrom
GrandMoff100 merged 1 commit intodevfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix error responses to include translation keys
Fix optional translation fields in websocket Error model
Mar 1, 2026
…in optional in Error model Co-authored-by: GrandMoff100 <51765903+GrandMoff100@users.noreply.github.com>
6b5d37d to
41cc4b6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #226 +/- ##
==========================================
+ Coverage 97.45% 97.46% +0.01%
==========================================
Files 25 25
Lines 1648 1655 +7
==========================================
+ Hits 1606 1613 +7
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GrandMoff100
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Assistant's websocket API doesn't always include
translation_key,translation_placeholders, andtranslation_domainin error responses, but theErrorPydantic model required them — causing aValidationErroron valid server responses likeinvalid_formaterrors.Changes
homeassistant_api/models/websocket.py: Madetranslation_key,translation_placeholders, andtranslation_domainoptional (Nonedefault) on theErrormodeltests/test_errors.py: Addedtest_error_model_without_optional_fieldsto assertErrorparses correctly with onlycodeandmessageOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.