Skip to content

Update deprecation lifecycle tagger#2029

Merged
loosebazooka merged 2 commits intomainfrom
update-deprecation-tagger
Mar 6, 2026
Merged

Update deprecation lifecycle tagger#2029
loosebazooka merged 2 commits intomainfrom
update-deprecation-tagger

Conversation

@loosebazooka
Copy link
Member

No description provided.

Signed-off-by: Appu Goundan <appu@google.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and safety of the image deprecation lifecycle script. By introducing a mandatory user confirmation step and refining the image selection logic to exclude actively updated images, it prevents unintended deprecations and provides clearer guidance to operators, ensuring a more controlled and secure process for managing image lifecycles.

Highlights

  • Enhanced Deprecation Logic: The script now intelligently skips images marked with 'update-available-' tags, preventing accidental deprecation of actively maintained images.
  • Mandatory User Confirmation: A new interactive prompt requires explicit user approval before proceeding with any image tagging, adding a critical safety layer.
  • Improved User Guidance: Added clear warnings and a direct link to the list of supported images, ensuring users are well-informed before initiating deprecation.
  • Activated Tagging Functionality: The exec_tag command, previously commented out, has been re-enabled, allowing the script to perform its intended deprecation tagging with the new safeguards in place.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • private/tools/lifecycle/tag.sh
    • Modified the jq filter to exclude images with update-available- tags from the deprecation target list.
    • Added a user confirmation prompt with explicit warnings and a link to supported images before executing the tagging operation.
    • Uncommented and re-enabled the exec_tag function call to perform the actual image tagging.
    • Updated comments to clarify the deprecation of cosign tag-based signatures.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🌳 🔧 Config Check

This pull request has not modified the root BUILD

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the deprecation lifecycle tagger script, making it safer and more user-friendly. The changes include refining the jq query to prevent deprecating images that are already marked for an update, and adding an interactive confirmation prompt before executing the tagging operation. My review includes one suggestion to improve script robustness by using printf instead of echo -e.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here

@loosebazooka loosebazooka requested a review from bobcallaway March 6, 2026 14:08
@loosebazooka loosebazooka merged commit 28078d2 into main Mar 6, 2026
14 checks passed
@loosebazooka loosebazooka deleted the update-deprecation-tagger branch March 6, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants