Buildifer fixes and remove unused config

[loosebazooka]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's build and CI setup by removing an outdated Travis CI configuration and improving the local linting experience. It also applies consistent formatting across various Bazel build files, enhancing readability and maintainability.

Highlights

• CI Configuration Removal: The .travis.yml file has been completely removed, indicating a deprecation of Travis CI for this repository.
• Buildifier Linting Improvements: The knife lint command now supports a --check flag, allowing buildifier to run in a validation-only mode without applying fixes.
• Bazel File Formatting: Numerous BUILD and .bzl files have had their load statements reordered, likely due to automatic formatting by buildifier for consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .travis.yml
  • Removed the Travis CI configuration file.
• BUILD
  • Reordered load statements for consistent formatting.
• cc/cc.bzl
  • Reordered load statements for consistent formatting.
• examples/nonroot/BUILD
  • Reordered load statements for consistent formatting.
• java/BUILD
  • Reordered load statements for consistent formatting.
• java/java.bzl
  • Reordered load statements for consistent formatting.
• knife
  • Modified the cmd_lint function to accept a --check argument, enabling buildifier to run in check-only mode.
  • Updated the lint command in the main script to pass arguments to cmd_lint.
• nodejs/BUILD
  • Reordered load statements for consistent formatting.
• nodejs/nodejs.bzl
  • Reordered load statements for consistent formatting.
• private/oci/defs.bzl
  • Reordered load statements for consistent formatting.
• private/oci/rust_image.bzl
  • Reordered load statements for consistent formatting.
• private/pkg/test/oci_image/BUILD.bazel
  • Reordered load statements for consistent formatting.
• python3/BUILD
  • Reordered load statements for consistent formatting.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/buildifier.yaml
  • .github/workflows/update-temurin-packages.yml

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily focuses on code cleanup and improving the development tooling. It successfully removes the obsolete .travis.yml configuration and applies buildifier formatting across numerous Bazel files, which standardizes the code style. Additionally, the knife script has been enhanced to support a --check mode for the linter. My review includes a suggestion to fix a bug in the find command within the knife script and make it more robust.

[gemini-code-assist]

This line has a couple of issues that could lead to incorrect behavior or errors:

1. Incorrect find logic: Due to operator precedence, -type f only applies to the last expression (-name '*.bzl'). This means directories matching BUILD* or WORKSPACE* could be passed to buildifier, which is not intended. You should group the -o conditions with parentheses.
2. Potential for error with many files: Using command substitution ($(...)) can cause an "Argument list too long" error if find returns a large number of files. A more robust approach is to pipe the output of find to xargs.

Using -print0 with find and -0 with xargs is also recommended to correctly handle filenames containing spaces or other special characters.

find . \( -name 'BUILD*' -o -name 'WORKSPACE*' -o -name '*.bzl' \) -type f -print0 | xargs -0 buildifier -mode="$mode"

[github-actions]

🌳 🔧 Config Check

This pull request has not modified the root BUILD

[github-actions]

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here