Skip to content

Add JAVA support for RISC-V#2022

Merged
loosebazooka merged 1 commit intoGoogleContainerTools:mainfrom
mmoll:rv64_java
Mar 3, 2026
Merged

Add JAVA support for RISC-V#2022
loosebazooka merged 1 commit intoGoogleContainerTools:mainfrom
mmoll:rv64_java

Conversation

@mmoll
Copy link
Contributor

@mmoll mmoll commented Feb 27, 2026

No description provided.

@mmoll
Copy link
Contributor Author

mmoll commented Feb 27, 2026

here are the build failures again 😅

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the distroless Java base images by adding support for the RISC-V architecture. This expansion ensures that applications built on these images can now be deployed on RISC-V platforms, broadening the utility and applicability of distroless images across diverse hardware environments.

Highlights

  • RISC-V Architecture Support: This pull request introduces support for the RISC-V architecture to the distroless Java base images.
  • Debian 13 Integration: The changes primarily focus on integrating RISC-V support into the Debian 13 distroless images for Java.
  • Configuration Updates: The configuration files have been updated to include RISC-V as a supported architecture for the Java base images.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • MODULE.bazel.lock
    • Updated the recordedFileInputs and versions for various Debian distributions and architectures.
  • README.md
    • Added riscv64 architecture to the list of supported architectures for java-base-debian13, java21-debian13 and java25-debian13.
  • java/config.bzl
    • Added riscv64 to the list of supported architectures for Debian 13.
  • private/repos/deb/trixie_adoptium.lock.json
    • Added metadata for temurin-17-jre, temurin-17-jdk, temurin-21-jre, temurin-21-jdk, temurin-25-jre and temurin-25-jdk for the riscv64 architecture.
  • private/repos/deb/trixie_adoptium.yaml
    • Added riscv64 to the list of supported architectures.
  • private/repos/deb/trixie_java.lock.json
    • Added metadata for fontconfig-config, fonts-dejavu-core, libbrotli1, libbz2-1.0, libcrypt1, libexpat1, libfontconfig1, libfreetype6, libglib2.0-0t64, libgraphite2-3, libharfbuzz0b, libjpeg62-turbo, liblcms2-2, libpcre2-8-0, libpng16-16t64, libuuid1, zlib1g, gcc-14-base, libgcc-s1 and libstdc++6 for the riscv64 architecture.
  • private/repos/deb/trixie_java.yaml
    • Added riscv64 to the list of supported architectures.
Activity
  • The pull request adds support for the RISC-V architecture to the distroless Java base images.
  • The configuration files were updated to include RISC-V as a supported architecture for the Java base images.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds support for the RISC-V architecture for Java on Debian 13 (Trixie). The changes include updating configuration files to include riscv64 as a supported architecture, adding corresponding package entries with their SHA256 hashes to the generated lock files, and updating the README.md documentation to reflect this new support. The changes are consistent with the stated objective and appear to be correctly implemented.

@loosebazooka
Copy link
Member

oh this just wont work with the current code setup, the debs contain zst archives for riscv64. I don't think rules_distroless supports this or we need to muck around with the config

@loosebazooka
Copy link
Member

oh wait no never mind, it's in our custom spdx generator. zst is supported by rules_distroless

@loosebazooka
Copy link
Member

loosebazooka commented Mar 2, 2026

try adding the extensions .tar.zst to /private/pkg/debian_spdx.bzl

@mmoll
Copy link
Contributor Author

mmoll commented Mar 3, 2026

woohoo 💚

@loosebazooka loosebazooka merged commit 2bbea5c into GoogleContainerTools:main Mar 3, 2026
10 checks passed
@mmoll mmoll deleted the rv64_java branch March 3, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants