Add JAVA support for RISC-V#2022
Conversation
|
here are the build failures again 😅 |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the distroless Java base images by adding support for the RISC-V architecture. This expansion ensures that applications built on these images can now be deployed on RISC-V platforms, broadening the utility and applicability of distroless images across diverse hardware environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for the RISC-V architecture for Java on Debian 13 (Trixie). The changes include updating configuration files to include riscv64 as a supported architecture, adding corresponding package entries with their SHA256 hashes to the generated lock files, and updating the README.md documentation to reflect this new support. The changes are consistent with the stated objective and appear to be correctly implemented.
|
oh this just wont work with the current code setup, the debs contain zst archives for riscv64. I don't think rules_distroless supports this or we need to muck around with the config |
|
oh wait no never mind, it's in our custom spdx generator. zst is supported by rules_distroless |
|
try adding the extensions |
|
woohoo 💚 |
No description provided.