-
Notifications
You must be signed in to change notification settings - Fork 6.7k
docs: sample migration deduplication #13804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chalmerlowe
wants to merge
2
commits into
main
Choose a base branch
from
doc-migration-deduplication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,8 @@ | ||
| google-cloud-storage==2.9.0; python_version < '3.7' | ||
| google-cloud-storage==2.9.0; python_version > '3.6' | ||
| google-cloud-compute==1.42.0 | ||
| google-cloud-storage==3.8.0 | ||
| google-auth==2.47.0 | ||
| pytest===8.4.2; python_version == '3.9' | ||
| pytest==9.0.2; python_version > '3.9' | ||
| boto3>=1.26.0 | ||
| requests==2.32.5 | ||
| python-dotenv==1.2.1 | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few issues with how
pytestis specified here:Test dependencies in production requirements:
pytestis a testing dependency and should not be included in the mainrequirements.txtfile. This will cause it to be installed in production environments where it's not needed. It's standard practice to keep test dependencies in a separate file, likerequirements-test.txtordev-requirements.txt.Incomplete Python version coverage: The
pytestdependency is only specified for Python 3.9 and greater. The project's previous test configuration (noxfile.py) supported Python 3.7 and 3.8. If these versions are still supported, tests will fail becausepytestwon't be installed. Please ensure test dependencies are available for all supported Python versions.Version specifier: For version pinning in
requirements.txt, the===operator is preferred to prevent automated updates from overwriting specific version numbers required for certain Python runtimes.I recommend removing these lines from this file and adding the corrected
pytestdependency to a dedicated test requirements file, ensuring===is used for version pinning.References
===operator inrequirements.txtfor version pinning to prevent automated updates from overwriting specific version numbers required for certain Python runtimes.