Refactor: add_goby_executable and add_goby_library CMake functions in GobyTarget.cmake, replace protobuf_generate_cpp_dccl

[Copilot]

Summary

Introduces a new cmake/GobyTarget.cmake file with add_goby_executable and add_goby_library convenience functions that consolidate the repetitive boilerplate used for every binary and library target in the project. Replaces the custom protobuf_generate_cpp_dccl with direct add_custom_command calls replicating the same --cpp_out + --dccl_out protoc invocation, and removes FindProtobufLocal.cmake in favor of CMake's standard find_package(Protobuf REQUIRED).

Changes

New cmake/GobyTarget.cmake

Defines two public functions and one internal helper:

add_goby_executable — build a Goby application binary (linking against goby and installing to bin are both implied):

add_goby_executable(TARGET goby3_example_basic_udpm_interprocess_publisher
  SOURCES publisher.cpp
  PROTOS config.proto
  LINK_LIBRARIES goby3_example_messages)

add_goby_library — build a Goby library target (SHARED by default; pass STATIC or MODULE to change):

add_goby_library(TARGET goby3_example_messages
  PROTOS nav.proto nav_dccl.proto gps.proto state.proto init.proto
  PROTOC_OUT_DIR ${project_INC_DIR}/messages
  LINK_LIBRARIES ${Protobuf_LIBRARIES} dccl)

Both functions accept TARGET, SOURCES, PROTOS, LINK_LIBRARIES, PROTO_IMPORT_DIRS, and PROTOC_OUT_DIR. Proto files are compiled via an internal _goby_generate_protos helper that issues add_custom_command with:

protoc --cpp_out <dir> <proto> -I<dirs>... --dccl_out <dir>

This matches the original protobuf_generate_cpp_dccl invocation pattern exactly, ensuring DCCL's insertion-point mechanism works correctly across all supported distros. add_goby_executable also calls generate_interfaces() automatically when export_goby_interfaces is ON, and automatically installs the target to bin.

cmake/FindProtobufLocal.cmake

Replaced with a stub comment. All its custom functions (PROTOBUF_GENERATE_CPP_DCCL, PROTOBUF_INCLUDE_DIRS) are removed.

Root CMakeLists.txt

• Bumped cmake_minimum_required to 3.13
• Replaced find_package(ProtobufLocal) with find_package(Protobuf REQUIRED)
• Added GOBY_PROTOBUF_IMPORT_DIRS variable (global protoc import paths used by both functions)
• Added include(GobyTarget)
• Simplified CMAKE_CXX_STANDARD guard to if(NOT CMAKE_CXX_STANDARD OR CMAKE_CXX_STANDARD LESS 17)

All binary CMakeLists.txt files (30+)

Every add_executable + proto codegen + target_link_libraries + install + generate_interfaces block replaced with a single add_goby_executable(...) call.

Library CMakeLists.txt files

src/messages/, src/components/acomms/modemdriver/pluggable_driver/, src/components/moos/gobyexample_protobuf/, and gps_moos_plugin updated to use add_goby_library.

Before / After Example

Before:

protobuf_generate_cpp_dccl(PROTO_SRCS PROTO_HDRS ${CMAKE_CURRENT_BINARY_DIR}
  config.proto)

add_executable(goby3_example_basic_udpm_interprocess_publisher
  publisher.cpp
  ${PROTO_SRCS} ${PROTO_HDRS})

target_link_libraries(goby3_example_basic_udpm_interprocess_publisher
  goby
  goby3_example_messages)

install(TARGETS goby3_example_basic_udpm_interprocess_publisher RUNTIME DESTINATION bin)

if(export_goby_interfaces)
  generate_interfaces(goby3_example_basic_udpm_interprocess_publisher)
endif()

After:

add_goby_executable(TARGET goby3_example_basic_udpm_interprocess_publisher
  SOURCES publisher.cpp
  PROTOS config.proto
  LINK_LIBRARIES goby3_example_messages)

[tsaubergine]

Please fix failing build. Also do something similar for the libraries (add_goby_library function)

[Copilot]

Please fix failing build. Also do something similar for the libraries (add_goby_library function)

Fixed in 7c90421.

Build failures: The root cause was protobuf_generate(LANGUAGE dccl ...) producing incompatible protoc invocations (insertion-point errors on jammy/bookworm; wrong output-path computation on noble). I replaced it with add_custom_command directly, replicating the exact --cpp_out ... --dccl_out pattern from the original protobuf_generate_cpp_dccl.

add_goby_library: Added to cmake/GobyApp.cmake alongside add_goby_executable. It takes TARGET, SOURCES, PROTOS, LINK_LIBRARIES, PROTO_IMPORT_DIRS, PROTOC_OUT_DIR, and optional STATIC/MODULE flags (defaults to SHARED). Updated src/messages, pluggable_driver, gobyexample_protobuf, and gps_moos_plugin to use it.

[tsaubergine]

Please rename to GobyTarget.cmake

[Copilot]

Done in 8303e61 — cmake/GobyApp.cmake renamed to cmake/GobyTarget.cmake and the include(GobyApp) in the root updated to include(GobyTarget).

[tsaubergine]

Add the install to the add_goby_executable function (for all excecutables)

[Copilot]

Done in 8303e61 — install(TARGETS ${args_TARGET} RUNTIME DESTINATION bin) added to add_goby_executable, and the 9 individual install(...) lines removed from the per-target CMakeLists.txt files.

[tsaubergine]

Write this more concisely if possible

[Copilot]

Done in 8303e61 — simplified to:

if(NOT CMAKE_CXX_STANDARD OR CMAKE_CXX_STANDARD LESS 17)