Open
Conversation
jhedstrom
force-pushed
the
31-content-type-subs
branch
from
0299343 to
f9ebe4d
Compare
- Starts on #31 - Excludes any Views, as config entities do not readily work with Views
jhedstrom
force-pushed
the
31-content-type-subs
branch
from
f9ebe4d to
de45ea9
Compare
|
Hello! Any chance of getting this released? Would be very interested to get this working with the flag content type functionality. |
iuliadanaila-tremend
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress, as when I dug deeper, the Views portion will just not be doable at this time. While there are Config Views, they do not support relationships to flaggings, and it felt like a rabbit hole.
We could merge just this bit, or move it to an example module. Alternatively, it wouldn't be too hard to write a non-view tab controller that would show a user their subscribed content types, and flags for ones they were not subscribed to.