Open
Conversation
🦋 Changeset detectedLatest commit: ed4cb6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
addisonschultz
added
the
new-integration
Collaborator
|
Hi @naagas-syft ! Thank you so much for adding your contribution to the GitBook integration platform. I have a few questions about the integration - would you be able to reach out to me at addison (@) gitbook.com? Thank you in advance! |
integrations/syft/src/index.tsx
Outdated
| { environment }: SyftRuntimeContext | ||
| ) => { | ||
| const syftId = | ||
| environment.spaceInstallation.configuration.syft_key ?? |
Collaborator
There was a problem hiding this comment.
Can you update this to environment.spaceInstallation?.configuration?.syft_key
This should fix the error you're seeing in the published site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We'd like to add integration that helps Syft customers to use Syft product on their Gitbook sites. We have many customers asking for this and we listened.
Changes
We took inspiration from other analytics gitbook integrations like posthog and heap. We require "script:inject" scope in order to inject our script.
Testing
I tried to publish in unlisted/private mode and failed to do so as the scope is restrictive. so, I couldn't really test this. Please guide me on how to test this.
Thanks and looking forward to a quick review.