solve issue with running tool when there are spaces in its path#1988
Open
denisbredikhin wants to merge 6 commits intoGitTools:mainfrom
Open
solve issue with running tool when there are spaces in its path#1988denisbredikhin wants to merge 6 commits intoGitTools:mainfrom
denisbredikhin wants to merge 6 commits intoGitTools:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build agent command execution helper to avoid Windows failures when the executable path contains spaces (as reported in #1912) by moving away from shell-based execution.
Changes:
- Replace
child_process.execwithchild_process.execFileto execute binaries directly (avoids path/quoting issues). - Normalize
stdout/stderrto strings for consistentExecResultoutput.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
arturcic
approved these changes
Mar 13, 2026
2 tasks
Member
|
@denisbredikhin please rebase the pr onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from child_process exec to execFile
Solves #1912