Conversation
jdeichert
reviewed
Apr 1, 2026
Contributor
jdeichert
left a comment
jdeichert
left a comment
There was a problem hiding this comment.
Leaving my stamp of approval (in draft mode) 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
Removed all the sections in favour of 4 new sections:
Motivations == Why Is This Changing?
Changes == What Is Changing?
Remaining sections reduced to:
Consumer Impact
Validation
Reviewer Notes
The goal is to track intent, outcome, impact and risk in a reduced set of fields.
Our Consumer Impact section will be interesting to see human filled versus danger-rule/deterministic check. It may highlight gaps in the danger-rule process, which is what the intention here is, to improve that danger rule over time.
Changes
Changed
Deprecated
Removed
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.