fix(components): Improve Alignment for Composable Page 'fill' Width#3025
Open
ZakaryH wants to merge 3 commits intomenu-position-prop-pleasefrom
Open
fix(components): Improve Alignment for Composable Page 'fill' Width#3025ZakaryH wants to merge 3 commits intomenu-position-prop-pleasefrom
ZakaryH wants to merge 3 commits intomenu-position-prop-pleasefrom
Conversation
Deploying atlantis with
|
| Latest commit: |
3d7c91a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://94c22019.atlantis.pages.dev |
| Branch Preview URL: | https://align-full-width-page-menu.atlantis.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
when a Page is 'fill' for width, that means it's flush against the edge. in that case, we have a visual line created along the rightmost edge. if our
Menudoesn't try to position along this same line, it breaks that visual line.so, when a Page is "fill" we should have a
"bottom end"placementChanges
Added
Changed
Deprecated
Removed
Fixed
applies an appropriate placement on the Menu when we have a "fill" Page. this only applies to the composable Page. the old one handles this totally differently, because it uses the old Menu.
Security
Testing
have a "fill" width Page with Menu items.
on master you'll see this
on this branch
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.