Skip to content

DO NOT MERGE: Combined branch for testing#3014

Draft
MichaelParadis wants to merge 138 commits intomasterfrom
MIKE/merged-bottom-sheet-content-overlay
Draft

DO NOT MERGE: Combined branch for testing#3014
MichaelParadis wants to merge 138 commits intomasterfrom
MIKE/merged-bottom-sheet-content-overlay

Conversation

@MichaelParadis
Copy link
Copy Markdown
Contributor

@MichaelParadis MichaelParadis commented Mar 26, 2026

Motivations

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Changes can be
tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

@edison-cy-yang
install react-native-bottom-sheet in components-native
0d471ea
@edison-cy-yang
added minimal BottomSheetRebuilt component
aaf2d30
@edison-cy-yang
basic bottomsheet styling and v9 story
fe12eb2
@edison-cy-yang
background and overlay style
f28af9e
@edison-cy-yang
ref can be directly accessed as a prop
6a26dc6
@edison-cy-yang
BottomSheet Footer
9c0cf71
@edison-cy-yang
support heading
eef6213
@edison-cy-yang
use handleChange to expose onClose and onOpen
398d915
@edison-cy-yang
cleanup props
88bd7b6
@edison-cy-yang
back to forwardRef and map existing API to react-native-bottom-sheet
aa0c61b
@edison-cy-yang
bottomsheet input text component with handle on focus and blur for bo…
36df1e1 
…ttom sheet and keyboard positioning
@edison-cy-yang
fixed footer overlapping content
414a864
@edison-cy-yang
add padding to bottom sheet input text
45d7667
@edison-cy-yang
make content flow behind the footer
7de3f5c
@edison-cy-yang
replace BottomSheet implementation with @gorhom/bottom-sheet, mock Bo…
376e1ec 
…ttomSheet
@edison-cy-yang
ship @gorhom/bottom-sheet as peerDep
07cd2c2
@edison-cy-yang
convert mockBottomSheet to export in ESM
5869f89
@edison-cy-yang
ship BottomSheetInputText as BottomSheet.InputText and use ref as a p…
07f9340 
…rop in BottomSheet
@edison-cy-yang
storybook v9 for BottomSheet
453723d
@edison-cy-yang
props json for InputText based components and BottomSheet
332d8f7
@edison-cy-yang
remove BottomSheet story book v7 and update doc site story link
ed67a7e
@edison-cy-yang
mock @gorhom/bottom-sheet for doc site
0f6f938
@edison-cy-yang
update dead link to Menu
f2cff43
@edison-cy-yang
update test to use userEvent
cbcb81f
@edison-cy-yang
explicit type annotation for animatedKeyboardState
8159b76
@edison-cy-yang
try to get aliases to apply before rollup resolves dependencies from …
a0298bc 
…node_modules
@edison-cy-yang
add @gorhom/bottom-sheet to modulesToTranspile
0aab050
@edison-cy-yang
add reanimated and bottom-sheet to optimizeDeps
04e42bd
@edison-cy-yang
remove react-native-reanimated from modulesToTranspile
bec688a
@edison-cy-yang
debug storybook vite build log
b316216
ZakaryH and others added 24 commits January 22, 2026 11:48
@ZakaryH
refactor(components-native): Refactor ContentOverlay for Behavior Cla…
c470ef0 
…rity (#2884)

* add behavior computation module with tests, implement in ContentOverlay

* clean up tests

* update spelling for consistency

* update logic to mirror existing

* revert back to position for top logic
@ZakaryH
update mobile storybook link
7718c53
@ZakaryH
provide explicit height to avoid blank space issue on Android
115d12f
@ZakaryH
feat(components-native): Manage ScrollView Issues with Keyboard Contr…
5e9052a 
…oller (#2889)

* add RNKC, use to fix SV issues in ContentOverlay

* prevent ts errors in mocks

* provide override for RNKC package

* add additional mocks for site

* add aliases for RN packages to avoid vite failures

* revert aliases, use exernal instead

* surgically correct package-lock state

* update package-lock dep locations
@Beccaneer
Merge branch 'master' into JOB-140606-implement-it-in-content-overlay
44f163c
@jdeichert
Merge remote-tracking branch 'origin/master' into JOB-140606-implemen…
2035cac 
…t-it-in-content-overlay
@jdeichert
Cleanup
4d3eb5a
@jdeichert
Merge remote-tracking branch 'origin/master' into JOB-140606-implemen…
722b15b 
…t-it-in-content-overlay
@jdeichert
Remove dupe entry
98518c1
@jdeichert
Restore version on master
a36a282
@MichaelParadis
Add dependencies to useImperativeHandle
f8d1d0f
@edison-cy-yang
conditionally handle keyboard aware scroll by KASV or bottom sheet in…
d437915 
…ternal state
@edison-cy-yang
Merge branch 'JOB-140606-implement-it-in-content-overlay' of github.c…
c17d0c6 
…om:GetJobber/atlantis into JOB-140606-implement-it-in-content-overlay
@jdeichert
Merge branch 'master' into JOB-140606-implement-it-in-content-overlay
c345242
@ZakaryH
swap to BottomSheetModal
d40e82e
@ZakaryH
remove and replace Host instances
b09898a
@edison-cy-yang
add bottomOffset to BottomSheetKeyboardAwareScrollView
0bd940c
@ZakaryH
remove duplicate import
81dfcaa
@ZakaryH
update meta
14194f5
@ZakaryH
update ThumbnailList snapshot for taupe update
c2752b5
@ZakaryH
fix order of meta
367bb27
@ZakaryH
remove unused disable
500f5ae
@ZakaryH
add mock for site bottomSheet
7727c4b
@MichaelParadis
Merge branch 'JOB-140606-implement-it-in-content-overlay' of github.c…
7a15608 
…om:GetJobber/atlantis into MIKE/merged-bottom-sheet-content-overlay
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026 •
edited
Loading

⚠️ Pull Request titles in this repo follow the Conventional Commits specification.

No release type found in pull request title "DO NOT MERGE: Combined branch for testing". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@MichaelParadis MichaelParadis changed the base branch from master to JOB-140606-implement-it-in-content-overlay March 26, 2026 20:58
@MichaelParadis MichaelParadis changed the base branch from JOB-140606-implement-it-in-content-overlay to master March 26, 2026 20:59
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 26, 2026

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a15608
Status: ✅  Deploy successful!
Preview URL: https://2bd9d3b5.atlantis.pages.dev
Branch Preview URL: https://mike-merged-bottom-sheet-con.atlantis.pages.dev

View logs

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Published Pre-release for 7a15608 with versions:

  - @jobber/components-native@0.98.3-MIKEmerge-7a15608.12+7a15608ce

To install the new version(s) for Mobile run:

npm install @jobber/components-native@0.98.3-MIKEmerge-7a15608.12+7a15608ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blocked

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelParadis @edison-cy-yang @jdeichert @ZakaryH @Beccaneer