Skip to content

refactor(components): EXPLORATION ONLY Menu + BottomSheet + Drawer + ActionItem DRAFT (DO NOT MERGE)#2984

Draft
scotttjob wants to merge 3 commits intomasterfrom
CLEANUP/menu-exploration
Draft

refactor(components): EXPLORATION ONLY Menu + BottomSheet + Drawer + ActionItem DRAFT (DO NOT MERGE)#2984
scotttjob wants to merge 3 commits intomasterfrom
CLEANUP/menu-exploration

Conversation

@scotttjob
Copy link
Copy Markdown
Contributor

@scotttjob scotttjob commented Mar 13, 2026

Motivations

  1. We're starting down the path of changing our design system.
  2. A lot of the ideas are a bit ephemeral right now, abstractions in documents.
  3. So in the interest of conversation, and figuring out our new path together as a team this PR represents the shape of how things COULD be in the future. Nothing in here is set in stone, it's meant to be a conversation starter.
  4. There was a conversation about Menu yesterday, and how Menu will work in the future.
  5. Currently our Menu behaves a bit differently at different screen widths.
  6. This PR shows how we could compose with different pieces in the future, to keep concerns separate without disturbing existing surfaces (too much).
image

This doesn't look right at all currently, this PR is purely for exploration purposes only. Please don't merge this.

Changes

  1. Refactors Menu to use BaseUI
  2. Splits shared Menu responsibility to 3 pieces, Menu.Popover, BottomSheet (using Drawer), ActionList (styled primitive, not exported).

Added

  • BottomSheet
  • ActionList
  • Primitive Base
  • BaseUI

Changed

  • Menu

Testing

  • Pull down the branch, run the docs site. I've updated the example to be in the new shape so you can see how you'd work with the layer. Then look at Menu.tsx to see how we're splitting up the responsibility.

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 13, 2026

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 69a9e98
Status: ✅  Deploy successful!
Preview URL: https://5f2a1578.atlantis.pages.dev
Branch Preview URL: https://cleanup-menu-exploration.atlantis.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant