Fix touch screen on Canvas and popLayer method.#414
Open
kynora wants to merge 1 commit intoGarageGames:developmentfrom
kynora:canvas
Open
Fix touch screen on Canvas and popLayer method.#414kynora wants to merge 1 commit intoGarageGames:developmentfrom kynora:canvas
kynora wants to merge 1 commit intoGarageGames:developmentfrom
kynora:canvas
Conversation
Contributor
kynora
commented
Apr 26, 2018
kynora
commented
- Touch screen coordinate on mobile device not correct when in portrait mode.
- Canvas.popLayer(); pop the last dialogs, not work with specific layer.
Contributor
|
You're basically switching back to the old code that was written before mobile devices were added. The functions that you're switching between are very similar except for a few bug fixes. If you switch back you might be fixing your problem but you are also reviving other bugs. It would be better to figure out a way to fix the new functions instead of just reverting back to the old ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.