fix: Add an error counter to stop workflow if one step failed#231
Open
RomainBaville wants to merge 6 commits intomainfrom
Open
fix: Add an error counter to stop workflow if one step failed#231RomainBaville wants to merge 6 commits intomainfrom
RomainBaville wants to merge 6 commits intomainfrom
Conversation
RomainBaville
added
type: bug
test-geos-integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a ParaView plugin of geos-pv the error managment is as follow:
If a plugin "a" calls another plugin "b", even if an error is raised during the call of the plugin "b", for the plugin "a" no error have been raised and do not stop.
This PR aims to user the handler "CountWarningsHanlder" renamed "CountVerbosityHandler" to not only count warnings but error and higher verbosity as well. With this counter, the plugin "b" can saved the number of error logged and the plugin "a" can tested it at the end of the application of the plugins "b".
This PR close #233