Fix inconsistent sharing fields between ProjectSerializer and ProjectDetailSerializer#60
Merged
RETR0-OS merged 2 commits intoclaude/graph-sharing-feature-x9qdtfrom Feb 23, 2026
Merged
Conversation
…ent API responses Co-authored-by: RETR0-OS <74290459+RETR0-OS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on graph sharing feature
Fix inconsistent sharing fields between ProjectSerializer and ProjectDetailSerializer
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an API contract inconsistency where ProjectDetailSerializer (used for retrieve operations) was missing the share_token and is_shared fields that were already exposed in ProjectSerializer (used for list/create operations). This made sharing status unavailable when fetching project details.
Changes:
- Added
share_tokenandis_sharedtoProjectDetailSerializer.Meta.fieldsto matchProjectSerializer - Added both fields to
read_only_fieldsto prevent client modification (consistent with server-side sharing management)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectDetailSerializer(used forretrieve) was missingshare_tokenandis_shared, whileProjectSerializer(used forlist/create) exposed both — making sharing status unavailable on the detail endpoint.Changes
ProjectDetailSerializer: Addedshare_tokenandis_sharedtofieldsandread_only_fields, matchingProjectSerializer's contract💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.