refactor: use lombok extension mechanism

[javier-godoy]

Summary by CodeRabbit

• Chores
  • Updated build configuration to optimize the development environment.
  • Refactored internal code structure for improved maintainability and consistency.

[coderabbitai]

Walkthrough

Lombok dependency scope updated from test to provided in pom.xml. ChipField.java adds Lombok extension method annotation and refactors JsonMigration utility calls to use extension methods instead of static method invocations.

Changes

Cohort / File(s)	Change Summary
Dependency configuration pom.xml	Lombok dependency scope changed from test to provided for build and packaging inclusion
Extension method integration src/main/java/com/flowingcode/vaadin/addons/chipfield/ChipField.java	Added Lombok @ExtensionMethod annotation to enable extension-style method calls; refactored JsonMigration static method calls (JsonMigration.getEventData(), JsonMigration.setPropertyJson()) to extension method syntax (e.getEventData(), getElement().setPropertyJson())

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify @ExtensionMethod configuration with suppressBaseMethods = true is correctly applied
• Ensure all JsonMigration static method calls have been consistently converted to extension method calls
• Confirm the Lombok scope change from test to provided aligns with intended build/development workflow expectations

Possibly related PRs

• feat: add json-migration-helper for compatibility with Vaadin 25 #83: Introduces JsonMigration helper integration for JSON compatibility; this PR refactors the integration approach by switching from direct static method calls to Lombok extension methods.

Suggested reviewers

• paodb

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main refactoring change: introducing Lombok extension methods to replace direct method calls throughout the codebase.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch lombok-refactor

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e051ce8 and ca9e5d4.

📒 Files selected for processing (2)

• pom.xml (1 hunks)
• src/main/java/com/flowingcode/vaadin/addons/chipfield/ChipField.java (5 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2024-11-08T19:36:02.414Z

Learnt from: paodb
Repo: FlowingCode/ChipFieldAddon PR: 0
File: :0-0
Timestamp: 2024-11-08T19:36:02.414Z
Learning: Ensure that AI-generated summaries accurately reflect the actual changes in the PR, particularly when the PR includes only Javadoc updates and plugin configuration changes.

Applied to files:

• pom.xml

🔇 Additional comments (3)

pom.xml (1)

191-191: Correct scope change for Lombok usage in production code.

The change from test to provided scope is appropriate since ChipField.java now uses Lombok's @ExtensionMethod annotation. Lombok is a compile-time annotation processor that generates code during compilation and doesn't need to be present at runtime.

src/main/java/com/flowingcode/vaadin/addons/chipfield/ChipField.java (2)

157-157: Refactoring of JsonMigration static methods has been successfully completed and is consistent throughout the codebase.

The search confirmed no remaining static method calls to JsonMigration exist in the code. The only match found is the @ExtensionMethod annotation declaration at line 68, which is the correct pattern enabling extension method usage. All conversions at the specified lines (157, 184, 203) and elsewhere have been uniformly applied.

---

53-53: Verify team consensus on experimental Lombok ExtensionMethod before proceeding.

@ExtensionMethod is explicitly marked experimental by Lombok with known practical limitations including poor IDE support, issues with lambdas and type inference, and compiler edge cases depending on JDK/javac/IDE versions. The refactoring is syntactically complete (all JsonMigration calls replaced; suppressBaseMethods = true correctly set), but the architectural decision to adopt this experimental feature requires team alignment.

Before merging, confirm:

• Team understands and accepts the experimental nature and limitations
• IDE support tested across your target JDK and development environments
• Any known compatibility issues with your toolchain addressed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud