Open
Conversation
FiXato
approved these changes
Jun 3, 2021
Owner
FiXato
left a comment
FiXato
left a comment
There was a problem hiding this comment.
Looks fine to me, even though alphanumeric characters might make it a bit trickier to later implement keyword filtering of the list.
Then again, I'm no longer actively developing/maintaining this script (I see I still have to merge in Flashcode's changes to make it python3 compatible), so I'm not sure if it's likely I'll ever implementing that filtering anyway. :)
I'll try to look at merging your PR later this week, as well as updating it for python3, and getting the update to the official weechat repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable 'q' to close the list buffer.