Skip to content

Comments

chore(round)!: Change Round.IgnoredPlayers to use Player#760

Open
Unbistrackted wants to merge 1 commit intoExMod-Team:masterfrom
Unbistrackted:IgnoredPlayers
Open

chore(round)!: Change Round.IgnoredPlayers to use Player#760
Unbistrackted wants to merge 1 commit intoExMod-Team:masterfrom
Unbistrackted:IgnoredPlayers

Conversation

@Unbistrackted
Copy link

Description

Describe the changes

What is the current behavior? (You can also link to an open issue here)
Round.IgnoredPlayers using Player

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Round.IgnoredPlayers hashset will be using Player instead of ReferenceHub

Other information:
Wanted to do this cause it's simple copy and paste in the IL side


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Unbistrackted
Copy link
Author

The only thing I'm curious is to why IgnoredPlayers has only a size of 20, I didn't changed since there might be a reason to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant