feat(warhead)!: Warhead.RemainingCooldown and WarheadStatus.OnCooldown#759
Open
Unbistrackted wants to merge 5 commits intoExMod-Team:masterfrom
Open
feat(warhead)!: Warhead.RemainingCooldown and WarheadStatus.OnCooldown#759Unbistrackted wants to merge 5 commits intoExMod-Team:masterfrom
Warhead.RemainingCooldown and WarheadStatus.OnCooldown#759Unbistrackted wants to merge 5 commits intoExMod-Team:masterfrom
Conversation
Change from ternary operators for readability Add case for ``WarheadStatus.OnCooldown``
Warhead.RemainingCooldown and WarheadStatus.OnCooldownWarhead.RemainingCooldown and WarheadStatus.OnCooldown
As per @louis1706 recommendation
Warhead.RemainingCooldown and WarheadStatus.OnCooldownWarhead.RemainingCooldown and WarheadStatus.OnCooldown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Add
OnCooldownforWarheadStatus, which I implemented it's logic intoWarhead.Status+ changed the ternary operators to if statements so it's more easy to readAdd
Warhead.RemainingCooldownso you don't have to use NetworkTime.time to change the cooldownWhat is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
I forgot to add
WarheadStatus.OnCooldownin the last pull requestTypes of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other