Open
Conversation
muskie82
force-pushed
the
corner_detection
branch
2 times, most recently
from
71c1fdf to
19a0c89
Compare
muskie82
force-pushed
the
corner_detection
branch
from
19a0c89 to
9ab7819
Compare
shiba24
commented
Jul 9, 2019
| usleep(ts - before_time); | ||
| } | ||
| pol = static_cast<bool>(pol_raw); | ||
| EventTuple tup = std::make_tuple(ts, x, y, pol_raw); |
Contributor
Author
There was a problem hiding this comment.
instead of deleting l37 (yes this may be a bug):
pol = static_cast<bool>(pol_raw);
EventTuple tup = std::make_tuple(ts, x, y, pol);
?
| Tuple of <int32_t timestamp, uint16_t x, uint16_t y, bool polarity>. | ||
| */ | ||
| typedef std::tuple<int32_t, uint16_t, uint16_t, bool> EventTuple; | ||
| typedef std::tuple<double, uint16_t, uint16_t, bool> EventTuple; |
Contributor
Author
There was a problem hiding this comment.
why did you change this?
| #include <tuple> | ||
| #include <memory> | ||
|
|
||
| #include <libcaercpp/libcaer.hpp> |
Contributor
Author
There was a problem hiding this comment.
why did you change the order here to l3?
| double a = cv::sum(dx2_)[0]; | ||
| double d = cv::sum(dy2_)[0]; | ||
| double b = cv::sum(dxy_)[0]; | ||
| double c = b; |
Contributor
Author
There was a problem hiding this comment.
do you need to define c?
| double c = b; | ||
| Eigen::Matrix2d M; | ||
| M << a, b, | ||
| c, d; |
| double a = cv::sum(dx2_)[0]; | ||
| double d = cv::sum(dy2_)[0]; | ||
| double b = cv::sum(dxy_)[0]; | ||
| double c = b; |
| double c = b; | ||
| Eigen::Matrix2d M; | ||
| M << a, b, | ||
| c, d; |
|
|
||
| int ret; | ||
| double ts, x, y, pol_raw; | ||
| std::queue<evl::EventTuple> que; |
Contributor
Author
There was a problem hiding this comment.
change the name to event_queue ?
Contributor
Author
There was a problem hiding this comment.
or something more informative
Contributor
Author
|
@muskie82 i reviewed. please see it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: