Issue 823 improve textcha for registration#1391
Issue 823 improve textcha for registration#1391ethancarlsson wants to merge 3 commits intoEuroPython:ep2021from
Conversation
| @@ -0,0 +1,18 @@ | |||
| # Generated by Django 2.2.19 on 2021-05-07 18:47 | |||
There was a problem hiding this comment.
Please recreate the migration (version 0030 is already taken by now) and rename the file to better explain what the migration is about.
There was a problem hiding this comment.
renamed the migration to "0032_add_instructions_to_textcha_question_verbose_name.py"
conference/models.py
Outdated
| answer = models.CharField(max_length=255) | ||
| answer = models.CharField(max_length=255, | ||
| verbose_name='''answer (use a regular expression | ||
| to capture possible answers e.g. |
There was a problem hiding this comment.
It's better to use separate string literals on each line, than using a long string with lots of spaces inside.
There was a problem hiding this comment.
I didn't know this, thank you. It should be corrected in the new change.
|
Could you please rebase the PR and address the above comments ? I think it's then time for merging it :-) |
ethancarlsson
force-pushed
the
issue-823-improve-textcha-for-registration
branch
from
d364970 to
39432c2
Compare
|
Fixed up the issues above and rebased it. This is my first time using rebase, so hopefully I've done it correctly. |
2 participants
#823
Textchas will now be created using regular expressions to allow multiple possible answers. Ignores case for all answers. Model now includes a verbose name describing the need to use regular expressions (and includes a migration to reflect this). Altered the test slightly to better test the new functionality.