Add tests for mixed deconstruction in C# 10#4081
Open
sharwell wants to merge 1 commit intoDotNetAnalyzers:masterfrom
Open
Add tests for mixed deconstruction in C# 10#4081sharwell wants to merge 1 commit intoDotNetAnalyzers:masterfrom
sharwell wants to merge 1 commit intoDotNetAnalyzers:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4081 +/- ##
========================================
Coverage 97.48% 97.49%
========================================
Files 1026 1037 +11
Lines 119387 119600 +213
Branches 3476 3476
========================================
+ Hits 116388 116602 +214
Misses 1986 1986
+ Partials 1013 1012 -1 🚀 New features to boost your workflow:
|
bjornhellander
suggested changes
Jan 10, 2026
|
|
||
| DiagnosticResult[] expected = | ||
| { | ||
| Diagnostic(DiagnosticId).WithSpan(6, 22, 6, 30), |
Contributor
There was a problem hiding this comment.
Any specific reason why markups are not used instead?
| { | ||
| [Fact] | ||
| [WorkItem(3990, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3990")] | ||
| public async Task TestMixedDeconstructionDoesNotReportUnnecessaryParenthesesAsync() |
Contributor
There was a problem hiding this comment.
Redundant because of the next test?
| } | ||
| }"; | ||
|
|
||
| await new CSharpTest() |
Contributor
There was a problem hiding this comment.
Use VerifyCSharpFixAsync instead, as normal? I don't realize from reading this PR if there's a reason for doing it differently in this test.
| } | ||
| }"; | ||
|
|
||
| await new CSharpTest() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3990