Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 43 43
Lines 3009 3010 +1
=======================================
+ Hits 2864 2865 +1
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tpoliaw the fact that this isn't making any tests fail is concerning |
|
We're never relying on bluesky calling it in tests and the system tests don't use numtracker |
3ec7d03 to
23996b6
Compare
|
Since we've moved on somewhat since this was opened: do we now use the call in system tests/is this tested, and if so does the change to make it async affect anything? Could we either get this tested and in, or close this PR? |
23996b6 to
b6cb2d2
Compare
|
Rebasing it on main still doesn't cause any tests to fail so I guess it works. This probably makes sense now that bluesky support async scan_id_sources. Whether we still want to merge this without removing other uses of requests is a separate question. |
b6cb2d2 to
08ad23d
Compare
08ad23d to
fc9782a
Compare
| ) | ||
| from ophyd_async.epics.motor import Motor | ||
| from pydantic import HttpUrl | ||
| from pytest_httpx import HTTPXMock |
There was a problem hiding this comment.
nit: explicitly import httpx_mock
|
|
No description provided.