Skip to content

LIMS-2034: Remove unused columns from main DC query#1044

Open
ndg63276 wants to merge 1 commit intomasterfrom
improvement/LIMS-2034/remove-unused-cols-from-dc-query
Open

LIMS-2034: Remove unused columns from main DC query#1044
ndg63276 wants to merge 1 commit intomasterfrom
improvement/LIMS-2034/remove-unused-cols-from-dc-query

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Mar 6, 2026

JIRA ticket: LIMS-2034

Summary:

The large query for the main data collection page includes getting columns that are never used in the front end. The columns are also badly labelled, making editing them hard.

Changes:

  • Don't fetch these values from the DataCollection table: voltage, c2aperture, c2lens, objaperture, magnification, numberofpasses, c1aperture, c1lens, c3aperture, c3lens, detectormode, slitgaphorizontal/vertical, binning, averagetemperature, nominalmagnification, nominaldefocus, imagesizex/y, pixelsizeonimage, phaseplate
  • Remap the RobotAction columns status and message as runstatus and comments respectively
  • Remove scon from the query as it never got anything from the db
  • Label what remains for easier editing in future

To test:

  • Go to a session with data collections, robot loads, edge scans and MCA spectra, eg /dc/visit/cm44137-1
  • Check each of those types appear as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants