Skip to content

Comments

Update physics step update for some spatial functors#144

Merged
yuecideng merged 5 commits intomainfrom
yueci/physics-step
Feb 20, 2026
Merged

Update physics step update for some spatial functors#144
yuecideng merged 5 commits intomainfrom
yueci/physics-step

Conversation

@yuecideng
Copy link
Contributor

@yuecideng yuecideng commented Feb 20, 2026

Description

This PR enhances the following things:

  • add physics_update_step for randomize_rigid_object_pose functor
  • update robot joint position setter for randomize_robot_eef_pose and randomize_robot_qpos

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

@yuecideng yuecideng added the enhancement New feature or request label Feb 20, 2026
Copilot AI review requested due to automatic review settings February 20, 2026 08:52
@yuecideng yuecideng added the gym robot learning env and its related features label Feb 20, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates gym launch configuration and spatial randomization functors to better control post-randomization physics stepping and to adjust how robot joint positions are applied during randomization.

Changes:

  • Disable dataset saving automatically when --preview mode is enabled.
  • Add an optional physics_update_step parameter to randomize_rigid_object_pose to apply physics steps after pose randomization.
  • Update robot EEF/qpos randomization to set non-target qpos before setting target qpos, and reduce the subsequent physics update step count.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
embodichain/lab/gym/utils/gym_utils.py Forces filter_dataset_saving=True when running in preview mode.
embodichain/lab/gym/envs/managers/randomization/spatial.py Adds physics stepping option for rigid object pose randomization; adjusts robot qpos application and physics stepping after robot randomization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yuecideng yuecideng merged commit bb4afa7 into main Feb 20, 2026
9 checks passed
@yuecideng yuecideng deleted the yueci/physics-step branch February 20, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gym robot learning env and its related features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant