Update physics step update for some spatial functors#144
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates gym launch configuration and spatial randomization functors to better control post-randomization physics stepping and to adjust how robot joint positions are applied during randomization.
Changes:
- Disable dataset saving automatically when
--previewmode is enabled. - Add an optional
physics_update_stepparameter torandomize_rigid_object_poseto apply physics steps after pose randomization. - Update robot EEF/qpos randomization to set non-target qpos before setting target qpos, and reduce the subsequent physics update step count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
embodichain/lab/gym/utils/gym_utils.py |
Forces filter_dataset_saving=True when running in preview mode. |
embodichain/lab/gym/envs/managers/randomization/spatial.py |
Adds physics stepping option for rigid object pose randomization; adjusts robot qpos application and physics stepping after robot randomization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the following things:
physics_update_stepforrandomize_rigid_object_posefunctorrandomize_robot_eef_poseandrandomize_robot_qposType of change
Checklist
black .command to format the code base.