Open
Conversation
Contributor
📝 WalkthroughWalkthroughA new Juiceswap adapter implementation is introduced that queries pool data and statistics from Ponder, retrieves on-chain token information via multiCall, fetches token prices, calculates TVL and APY metrics for liquidity pools, and exports these metrics through an Changes
Sequence DiagramsequenceDiagram
participant Adapter as Adapter<br/>(index.js)
participant Ponder as Ponder<br/>GraphQL
participant OnChain as On-Chain<br/>multiCall
participant PriceAPI as Price<br/>Data
participant Result as Output
Adapter->>Ponder: Query pools & 24h stats
Ponder-->>Adapter: Pool list + volume data
Adapter->>OnChain: Fetch token symbols<br/>& decimals (erc20:*)
OnChain-->>Adapter: Token metadata
Adapter->>OnChain: Fetch pool reserves<br/>(balanceOf)
OnChain-->>Adapter: reserve0, reserve1
Adapter->>PriceAPI: Get USD prices<br/>for all tokens
PriceAPI-->>Adapter: Token prices
Adapter->>Adapter: Calculate TVL<br/>& APY metrics
Adapter->>Result: Output pool data<br/>(address, TVL, APY,<br/>symbol, underlyingTokens)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
|
The juiceswap adapter exports pools: Test Suites: 1 passed, 1 total |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/adaptors/juiceswap/index.js (2)
55-55: Add an early return for empty pool sets.If the pool query returns no items, we can skip multicalls and price fetches entirely. This reduces upstream load and avoids unnecessary external-call failure surface.
Suggested fast-path
const pools = poolsData.pools.items; + if (!pools.length) return [];Also applies to: 61-99
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/juiceswap/index.js` at line 55, The result handling should short-circuit when the pool query returns no items: after assigning const pools = poolsData.pools.items, add an early return when pools is falsy or length===0 to skip the subsequent multicall and price-fetch logic and return an appropriate empty result (e.g., [] or the function's empty-response shape). Apply the same fast-path check to the other similar block in this file around the multicall/price-fetch sequence so you avoid unnecessary external calls and downstream errors.
13-13: Avoid silent truncation when query results hit the 1000 cap.Both datasets are hard-capped at 1000, and the adapter currently continues silently if that cap is reached. That can underreport pools/stats without any signal.
Suggested guard (fail loudly when cap is hit)
const pools = poolsData.pools.items; + if (pools.length === 1000) { + throw new Error('JuiceSwap pools query reached limit=1000; add pagination before continuing'); + } const statsMap = Object.fromEntries( statsData.poolStats.items.map((s) => [s.poolAddress.toLowerCase(), s]) ); + if (statsData.poolStats.items.length === 1000) { + throw new Error('JuiceSwap stats query reached limit=1000; add pagination before continuing'); + }Also applies to: 28-28, 55-58
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/juiceswap/index.js` at line 13, The GraphQL query uses a hard limit of 1000 on "pools" (pools(where: { chainId: $chainId }, limit: 1000)), which can silently truncate results; update the adapter to detect when the returned array length equals 1000 and fail loudly (throw or log an error and stop) so callers are alerted to truncation. Apply the same guard for the other capped queries in this file (the other occurrences of limit: 1000 around the pools/stat collection and the block that processes query results) by checking the corresponding response arrays before continuing and surfacing a clear error mentioning the query name (e.g., "pools") and chainId so the issue can be investigated.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/adaptors/juiceswap/index.js`:
- Line 55: The result handling should short-circuit when the pool query returns
no items: after assigning const pools = poolsData.pools.items, add an early
return when pools is falsy or length===0 to skip the subsequent multicall and
price-fetch logic and return an appropriate empty result (e.g., [] or the
function's empty-response shape). Apply the same fast-path check to the other
similar block in this file around the multicall/price-fetch sequence so you
avoid unnecessary external calls and downstream errors.
- Line 13: The GraphQL query uses a hard limit of 1000 on "pools" (pools(where:
{ chainId: $chainId }, limit: 1000)), which can silently truncate results;
update the adapter to detect when the returned array length equals 1000 and fail
loudly (throw or log an error and stop) so callers are alerted to truncation.
Apply the same guard for the other capped queries in this file (the other
occurrences of limit: 1000 around the pools/stat collection and the block that
processes query results) by checking the corresponding response arrays before
continuing and surfacing a clear error mentioning the query name (e.g., "pools")
and chainId so the issue can be investigated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0bf4cef9-4870-4764-b48a-be4587817c15
📒 Files selected for processing (1)
src/adaptors/juiceswap/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds JuiceSwap on Citrea.
https://juiceswap.com/#/
Summary by CodeRabbit
New Features