Skip to content

fix: better validation of CAST ... as numeric #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mozart-segfy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: better validation of CAST ... as numeric #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sqlvalidator/grammar/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,11 @@ def __str__(self):

def validate(self, known_fields):
errors = super().validate(known_fields)
for a in self.args:
if self.function_name == 'cast':
tovalidate = [xa for xa in self.args if xa != 'AS']
else:
tovalidate = self.args
for a in tovalidate:
errors += a.validate(known_fields)
return errors

Expand Down Expand Up @@ -835,7 +839,7 @@ def validate(self, known_fields):


class Type(Expression):
VALUES = ("int", "float", "day", "month", "timestamp", "int64", "string", "date")
VALUES = ("int", "float", "day", "month", "timestamp", "int64", "string", "date", "numeric")

def __str__(self):
return self.value.upper()
Expand Down