refactor: Replace JBang with javax.tools.JavaCompiler for UDF compilation#1969
Open
refactor: Replace JBang with javax.tools.JavaCompiler for UDF compilation#1969
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
============================================
+ Coverage 13.11% 13.27% +0.16%
Complexity 780 780
============================================
Files 592 593 +1
Lines 16848 16908 +60
Branches 1971 1974 +3
============================================
+ Hits 2210 2245 +35
- Misses 14435 14459 +24
- Partials 203 204 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
UDF Container Test Performance
From CircleCI logs — same test, same Docker container setup, just the UDF compilation path changed. |
9ad8c4d to
ed79a39
Compare
…tion Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…R at runtime Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…ove TOCTOU Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
e41c3f2 to
799da83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javax.tools.JavaCompilerfor compiling Flink UDF.javascriptseu.maveniverse.mima) for resolving//JDEPSMaven dependencies (replaces JBang's//DEPS)Changes
UdfCompiler— compiles UDF sources and packages into JAR usingjavax.tools.JavaCompilerMavenDependencyResolver— parses//JDEPSand resolves artifacts via Mima embedded Maven resolverJavaUdfPreprocessor— replacesJBangPreprocessor, auto-detects.javafiles extending Flink UDF classesJBangRunner,JBangPreprocessorand their testsTest plan
JavaUdfContainerIT) — requires Docker image rebuild🤖 Generated with Claude Code