Skip to content

fix: support multiple EXECUTE STATEMENT SET blocks in session mode#309

Closed
velo wants to merge 3 commits intomainfrom
fix/multiple-statement-sets-session-mode
Closed

fix: support multiple EXECUTE STATEMENT SET blocks in session mode#309
velo wants to merge 3 commits intomainfrom
fix/multiple-statement-sets-session-mode

Conversation

@velo
Copy link
Copy Markdown
Collaborator

@velo velo commented Mar 20, 2026

Summary

  • Fixes tableResult.await() failing in session mode (FlinkSessionJob) when SQL scripts contain multiple EXECUTE STATEMENT SET blocks
  • awaitCompletion() tries await() first (application mode), falls back to polling jobClient.getJobStatus() (session mode)
  • Adds .sdkmanrc for Java 17 and renames CLAUDE.md to AGENTS.md with ADR section

Test plan

  • Unit tests: 4 new tests in SqlExecutorTest covering await success, polling fallback, job failure, and multi-statement-set execution
  • Integration test: MultipleStatementSetsIT verifies both statement sets execute in batch mode with print output verification
  • All 67 unit tests pass
  • IT passes locally

Fixes #308

🤖 Generated with Claude Code

velo added 2 commits March 20, 2026 14:53
)

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo velo requested a review from ferenc-csaky March 20, 2026 18:05
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@ferenc-csaky
Copy link
Copy Markdown
Collaborator

After trying this out with the K8s operator, unfortunately this also does not solve the problem, hence closing.

@ferenc-csaky ferenc-csaky deleted the fix/multiple-statement-sets-session-mode branch March 31, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple EXECUTE STATEMENT SET blocks fail in session mode

2 participants