[BDMS-420] AOUIWL the field compilation sheet to be on one page#185
[BDMS-420] AOUIWL the field compilation sheet to be on one page#185TylerAdamMartinez wants to merge 11 commits intostagingfrom
Conversation
OLD VERSION
|
OLD VERSIONGrabacion.de.pantalla.2026-02-24.a.la.s.15.20.24.mov |
TylerAdamMartinez
requested review from
jacob-a-brown,
jeremyzilar and
marissafichera
|
Okay I have a large enough review that I assigned a different jira ticket. BDMS-271 This may have to wait until next sprint unless higher ups okay it at tomorrow's standup, but I think there needs to be some data cleanup on this PDF before we move forward with this PR. |
jacob-a-brown
left a comment
jacob-a-brown
left a comment
There was a problem hiding this comment.
I made a comment about Well Id, which comes from well.name. After I made that comment I noticed that well.name was mapped to Well Id in the PDF in multiple plaes. Rather than make the same comment many times I figured I could just leave that one open and if changes need to be made for that comment they'd apply elsewhere too.
| </View> | ||
| <View style={styles.cell3}> | ||
| <LineItem | ||
| title="Last Depth to Water" |
There was a problem hiding this comment.
Should this be Last Depth to Water BGS since that is the attribute that is being pulled?
| if (!primary) { | ||
| primary = normalized.find((c) => c._normalizedType === 'owner') | ||
| } | ||
|
|
||
| if (!primary) { | ||
| primary = normalized[0] | ||
| } |
There was a problem hiding this comment.
Should these be else if statements? That way the program won't run these lines if one of the previous if statements evaluates to true
|
I like how modular the PDF is! And that users can add or remove items as they want. I also like how it can be condensed into one page. |
|
|
@TylerAdamMartinez Looks great overall. I think the left and right margins could be increased without increasing the total page count. Question for @marissafichera: the hydrograph is depth below ground surface, wouldn't field techs want depth to water from measuring point? |
4 participants
Why
This PR addresses the following problem/context:
How
Implementation summary - the following was changed/added/removed:
'very-dense'the default density whenoptions.densityis not explicitly provided (previously 'normal').Notes
Any special considerations, workarounds, or follow-up work to note?
'very-dense'makes text quite small (~9–11px). On a phone/tablet PDF viewer, it's still legible, but printing at 100% may require reading glasses for some people.