Conversation
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 4e192ba | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
28f5924 to
4e192ba
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e192baaca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @parametrize("library_env", [{"DD_SERVICE": "global-service"}]) | ||
| def test_base_service_set_when_service_overridden(self, test_agent: TestAgentAPI, test_library: APMLibrary) -> None: |
There was a problem hiding this comment.
Skip DD_SERVICE-dependent base_service test where unsupported
This new test assumes DD_SERVICE is reliably applied (_dd.base_service must equal global-service), but many libraries already declare that same prerequisite as unsupported in existing manifests (for example tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable is marked missing_feature in manifests/nodejs.yml and manifests/dotnet.yml because the test client sets an empty service). Adding this class without corresponding manifest gating will make parametric runs fail for those libraries for a known pre-existing limitation rather than the feature under test.
Useful? React with 👍 / 👎.
nccatoni
left a comment
There was a problem hiding this comment.
LGTM (for @DataDog/system-tests-core) but you should get a review from someone familiar with the feature
I think I'm the most familiar one today :) |
Motivation
Adds end-to-end and parametric tests to verify that tracers correctly set the
_dd.base_servicemeta tag on spans whose service name differs from the global configured service (DD_SERVICE).End-to-end tests (
tests/integrations/test_base_service.py):Test_BaseService_RootSpan— verifies that the root/entry span never carries_dd.base_service(its service is the global service)Test_BaseService_SqlSpan— verifies that SQL spans produced by database integrations carry_dd.base_servicepointing back to the global service, using the/rasp/sqliendpoint (since that endpoint will create an override systematically)Parametric tests (
tests/parametric/test_tracer.py):Test_TracerBaseService::test_base_service_set_when_service_overridden— creates a child span with an overridden service name and asserts_dd.base_serviceis set toDD_SERVICETest_TracerBaseService::test_base_service_absent_when_service_not_overridden— asserts_dd.base_serviceis absent when the span service matchesDD_SERVICE*Notes: it seems that in Ruby that's not correctly implemented since the simple parametric test case is not passing
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present