Skip to content

Enable process tags tests for service name in dotnet#6583

Merged
amarziali merged 1 commit intomainfrom
andrea.marziali/dotnet-processtags
Mar 25, 2026
Merged

Enable process tags tests for service name in dotnet#6583
amarziali merged 1 commit intomainfrom
andrea.marziali/dotnet-processtags

Conversation

@amarziali
Copy link
Contributor

Motivation

Enable service name related process tags in dotnet.

Notes:

  1. Process tags are not yet enabled by default in dotnet so I forced the configuration (to be removed when all the languages will switch them on)
  2. I took the occasion to fix the check since the tests did not apply the normalisation expected (I simplified with lowercasing that's good enough)

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@amarziali amarziali requested review from a team as code owners March 25, 2026 09:24
@amarziali amarziali requested review from genesor and removed request for a team March 25, 2026 09:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2026

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
tests/parametric/test_tracer.py                                         @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@amarziali amarziali force-pushed the andrea.marziali/dotnet-processtags branch from 84a7a78 to ddcc21d Compare March 25, 2026 09:26
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84a7a78bd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@amarziali amarziali enabled auto-merge (squash) March 25, 2026 09:34
@amarziali amarziali merged commit 6f47f6e into main Mar 25, 2026
442 checks passed
@amarziali amarziali deleted the andrea.marziali/dotnet-processtags branch March 25, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants