v1 protocol: Implemented replay support for auto_inject tests.#6582
v1 protocol: Implemented replay support for auto_inject tests.#6582AlexeyKuznetsov-DD wants to merge 1 commit intomainfrom
auto_inject tests.#6582Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c90e1f3d22
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| prefix = "Http request done with uuid: [" | ||
| if msg.startswith(prefix): | ||
| return msg.removeprefix(prefix).split("]", 1)[0] |
There was a problem hiding this comment.
Don’t derive replay UUID solely from "Http request" log
Replay UUID extraction assumes the JSON report contains a log entry starting with "Http request done with uuid: [", but that message is only emitted in the non-krunvm request path; _check_install()’s krunvm branch does not log this prefix. For krunvm-based auto-inject runs, replay will consistently raise Could not find recorded request uuid... even though the original run succeeded.
Useful? React with 👍 / 👎.
| assert validator(request_uuid, trace_data), ( | ||
| f"{validator.__name__} failed to validate trace_id: {request_uuid}" | ||
| ) | ||
| return |
There was a problem hiding this comment.
Preserve profiling assertions in replayed install checks
In replay mode, _test_install(..., profile=True) returns before any profiling validation is performed, so profiling tests become pass-throughs. This is a regression in replay semantics for profiling scenarios: if a code change breaks profiling assertions, replayed tests will still pass because the replay branch does not check recorded profile artifacts (despite now persisting them in replay_profiles).
Useful? React with 👍 / 👎.
Motivation
Support
v1protocol fordd-trace-javaChanges
Implemented replay support for
auto_injecttests.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present