Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 037655441a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2cd300f54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # [CHANGED] Use subclauses directly instead of the library's prerelease split. | ||
| # The library separates prerelease/non-prerelease clauses and recombines them | ||
| # with extra bounds, which breaks direct prerelease comparison. | ||
| result |= AllOf(*subclauses) |
There was a problem hiding this comment.
Preserve release match for exact prerelease declarations
Using result |= AllOf(*subclauses) drops the upstream parser’s prerelease/non-prerelease companion branch, which changes existing manifest behavior for exact prerelease pins: SemverRange("1.61.0-SNAPSHOT") stops matching 1.61.0 after this commit. Fresh evidence is in manifests/java.yml, which has inline 1.61.0-SNAPSHOT activations for telemetry tests; with this change, Java 1.61.0 is now treated as still missing_feature, so those tests can be skipped/incorrectly deactivated for the release build.
Useful? React with 👍 / 👎.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present