Conversation
The code as is is prior to cancellations. Now that we support cancellations we can simplify it, by making sure that we always cancel the request once we're done sleeping.
This method takes a slice from the sqe queue, but that is completely wrong: the sqe queue is a circular buffer, so if you try to get 2 elements at position n - 1 you access invalid memory. This patch transforms the very helpful SQEs structure so that it now only has the information needed to access each SQE and constructs them from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies the link ring code - where I suspected a bug (unconfirmed, but the simplification is good), and fixes a serious problem in the code coming from iou.
A similar patch was sent to iou
Motivation
My app was behaving like it was possessed by the devil.
Related issues
ringbahn/iou#66