feat: slim down the zip ddtrace package#752
Closed
juanjux wants to merge 9 commits intoDataDog:mainfrom
Closed
Conversation
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Member
brettlangdon
left a comment
There was a problem hiding this comment.
if you have an analysis of the non-py/binary files from a layer artifact, could be nice to have in the PR description, or even just a "count of files by extension", would be interesting to see what else might be there
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
…njux/datadog-lambda-python into juanjux/remove-ddtrace-stuff
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
…njux/datadog-lambda-python into juanjux/remove-ddtrace-stuff
Author
|
Updated the PR removing some filetypes that should not be anymore after hhttps://github.com/DataDog/dd-trace-py/pull/17020 is merged |
Author
|
Closing, will be reopened from a branch inside this repo as instructed by @purple4reina |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove some vestigial things, text files and unused libs.
How
I build the layer with:
And with the help of the clanker started to look into things that should be 100% safe to delete.
Motivation
Not having new ddtrace releases blocked by the package size.
Files by extension
As suggested by @brettlangdon