-
Notifications
You must be signed in to change notification settings - Fork 17
feat(triggers): handle MSK events #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joeyzhao2018
wants to merge
25
commits into
main
Choose a base branch
from
joey/handle_msk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+323
−16
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
513f0ca
handle MSK events
joeyzhao2018 fe2c84b
cargo fmt and merge main
joeyzhao2018 1dbb7d6
fix
joeyzhao2018 4683724
cargo fmt
joeyzhao2018 e731d52
Merge branch 'main' into joey/handle_msk
joeyzhao2018 b13ade2
Merge branch 'main' into joey/handle_msk
joeyzhao2018 22b24a2
fix critical vulnerability
joeyzhao2018 9f9af1f
Merge branch 'main' into joey/handle_msk
joeyzhao2018 40cd56f
fix(msk): handle real-world header format from Java Lambda runtime
joeyzhao2018 9dbcb53
Merge branch 'main' into joey/handle_msk
joeyzhao2018 f64e583
fix(msk): fix clippy lints in msk_event header parsing
joeyzhao2018 46014bb
cargo fmt
joeyzhao2018 79fe393
Potential fix for pull request finding
joeyzhao2018 8df55f0
Merge branch 'main' into joey/handle_msk
joeyzhao2018 148d9f3
rename method and update comment
joeyzhao2018 9ff4e25
cargo fmt
joeyzhao2018 dd16016
updates based on codex suggestions
joeyzhao2018 26c328f
Merge branch 'main' into joey/handle_msk
joeyzhao2018 aa37257
find the first record with actual tracecontext and remove the unnecce…
joeyzhao2018 bb20187
Potential fix for pull request finding
joeyzhao2018 89fee19
Potential fix for pull request finding
joeyzhao2018 e321cf8
fixing issues from codex commits
joeyzhao2018 1b1427d
clippy fix
joeyzhao2018 3c9ab3b
codex suggested fixes
joeyzhao2018 509a079
cargo fmt
joeyzhao2018 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "eventSource": "aws:kafka", | ||
| "eventSourceArn": "arn:aws:kafka:us-east-1:123456789012:cluster/demo-cluster/751d2973-a626-431c-9d4e-d7975eb44dd7-2", | ||
| "bootstrapServers": "b-1.demo-cluster.a1bcde.c1.kafka.us-east-1.amazonaws.com:9092,b-2.demo-cluster.a1bcde.c1.kafka.us-east-1.amazonaws.com:9092", | ||
| "records": { | ||
| "demo-topic-0": { | ||
| "0": { | ||
| "topic": "demo-topic", | ||
| "partition": 0, | ||
| "offset": 101, | ||
| "timestamp": 1745846213022, | ||
| "timestampType": "CREATE_TIME", | ||
| "key": "b3JkZXJJZA==", | ||
| "value": "eyJvcmRlcklkIjoiMTIzNCIsImFtb3VudCI6MTAwLjAxfQ==", | ||
| "headers": { | ||
| "0": {"someId": ["70","114","111","109","66","114","117","110","111"]}, | ||
| "1": {"anotherId": {"0":"55","1":"52","2":"50","3":"101","4":"101","5":"101","6":"52","7":"57","8":"45","9":"101","10":"51","11":"100","12":"55","13":"45","14":"52","15":"51","16":"52","17":"54","18":"45","19":"97","20":"54","21":"57","22":"57","23":"45","24":"52","25":"100","26":"49","27":"56","28":"101","29":"99","30":"98","31":"53","32":"53","33":"101","34":"50","35":"99"}}, | ||
| "2": {"x-datadog-trace-id": {"0":"49","1":"52","2":"57","3":"55","4":"49","5":"49","6":"54","7":"48","8":"49","9":"49","10":"55","11":"51","12":"56","13":"54","14":"52","15":"52","16":"55","17":"54","18":"56"}}, | ||
| "3": {"x-datadog-parent-id": {"0":"50","1":"50","2":"51","3":"57","4":"56","5":"48","6":"49","7":"53","8":"56","9":"51","10":"48","11":"55","12":"55","13":"51","14":"48","15":"52","16":"48","17":"52","18":"50"}}, | ||
| "4": {"x-datadog-sampling-priority": ["49"]}, | ||
| "5": {"x-datadog-tags": {"0":"95","1":"100","2":"100","3":"46","4":"112","5":"46","6":"100","7":"109","8":"61","9":"45","10":"49","11":"44","12":"95","13":"100","14":"100","15":"46","16":"112","17":"46","18":"116","19":"105","20":"100","21":"61","22":"54","23":"57","24":"57","25":"99","26":"56","27":"51","28":"54","29":"53","30":"48","31":"48","32":"48","33":"48","34":"48","35":"48","36":"48","37":"48"}} | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The concern is real but the optimization is premature here. The Lambda payload cap is 6MB total, so even in the worst case the clone is bounded. The locator adds a non-trivial amount of complexity (new enum, more complex extraction logic) for a one-time cost per invocation on what's already a cold path. The current code is significantly easier to read and maintain. " by Claude Code